Talk:Music Player Daemon Version 2 Plans
From Music Player Daemon Community Wiki
Ok it's bad enough that peoples OO and C++ bad habits are more than obvious in the current MPD implementation, but going OO or to C++ will be the straw that broke this camels back.
- shank (the original author) himself admits that the initial codebase was ugly. Since then it has never had a thorough cleaning, and so much of it remains as ugly as it was, or worse due to new code being hacked on. But pretty much all recent changes have been relatively clean, and the entire tree has been run through indent, so it at least has a cleaner code style now. If MPD were to be rewritten in C++, it would be a fresh codebase, which would be far cleaner than the current MPD.
- --Jat 20:32, 8 December 2006 (UTC)
First off libmpdclient is just ugly, and very poorly documented.
- For ugly, see above. Documentation is indeed shit, but on the TODO (qball already has already started on some excellent libmpd documentation.
- --Jat 20:32, 8 December 2006 (UTC)
Secondly the use of CamelCase functions makes it difficult to read.
- This is a style thing. Many people use CamelCase because they like it. Get used to it.
- --Jat 20:32, 8 December 2006 (UTC)
Look I love the simplicity of mpd, but if this shit doesn't get cleaned up I'm ditching my Enlightenment (EFL) client, and working on something else.
- If you're writing a client, the only thing you should really care about is documentation for libmpdclient, and as noted that's already a priority.
- --Jat 20:32, 8 December 2006 (UTC)
sphorner AT gmail DOT com
PS - All of the above is also why I won't contribute to MPD itself.
- Ugly code is not a good reason to avoid contributing. Someone has to contribute the code cleanups in the first place.
- Idle threats and bitching will not cleanup the MPD code. Patches will.
- --Jat 20:32, 8 December 2006 (UTC)
I mean seriously look at xmmsc for the new xmms2; it's logical, and beautiful.
[edit] No C++
C++ is a bad language. It is unnecessarily complex, difficult to write and understand, promotes terrible coding habits, and there are no standards compliant compilers! I'm not sure about ruby or python, but I know a lot of the good scripting languages can be compiled to native binaries, or to C, by now. So embedded systems should be fine. What other argument could there be for writing it in C++? Speed is a non-issue for this project I should think. It doesn't need to handle 8,000 concurrent requests, or anything like that. The only thing I can think of where speed might be an issue is in handling very large playlists. So write those bits in C, perhaps. But for heaven sakes, there is no reason to write the vast majority of the project in a low-level language anymore. So don't!
[edit] Don't be so negative
It's fine to give feedback, but please don't make it an (personal) attack.
[edit] Response from Stephen
I'm sorry for the negativity, I was quite a jerk when I wanted to be back then. I'm sure you guys have been working very hard to make the code base better, if it isn't there yet (i've been away awhile). Keep on keeping on guys, I still love MPD and use it daily. Peace and Love, Stephen